Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLUGIN-1742] Added S3EmptyInputFormat #5

Merged
merged 1 commit into from
Aug 30, 2024
Merged

[PLUGIN-1742] Added S3EmptyInputFormat #5

merged 1 commit into from
Aug 30, 2024

Conversation

psainics
Copy link
Collaborator

@psainics psainics commented Mar 1, 2024

Added S3EmptyInputFormat

Jira : PLUGIN-1742

Description

  • Plugins that extend from AbstractFileSource (link) which are outside of the Core Plugins module will not correctly export the EmptyInputFormat !

  • This PR implements a S3EmptyInputFormat that will be used when file is empty !

UI Field

  • No Changes made to widget json.

Docs

  • No Changes made to docs.

Code change

  • Added S3EmptyInputFormat.java
  • Modified S3BatchSource.java

Unit Tests

  • No Changes made to unit tests.

@psainics psainics added the bug Something isn't working label Mar 1, 2024
@psainics psainics requested a review from vikasrathee-cs March 1, 2024 04:14
@psainics psainics self-assigned this Mar 1, 2024
@psainics psainics force-pushed the patch/empty-format-class-loading-bug branch from 660f32f to 1f2e351 Compare April 4, 2024 02:52
@psainics psainics force-pushed the patch/empty-format-class-loading-bug branch from 1f2e351 to 34e347c Compare April 16, 2024 08:29
@psainics psainics force-pushed the patch/empty-format-class-loading-bug branch from 34e347c to d7616a2 Compare May 21, 2024 05:21
@psainics
Added S3EmptyInputFormat
bc65e1f 
# Conflicts:
#	pom.xml
@psainics psainics force-pushed the patch/empty-format-class-loading-bug branch from d7616a2 to bc65e1f Compare August 30, 2024 10:36
@psainics psainics merged commit 7cb0bcd into develop Aug 30, 2024
1 check passed
@psainics psainics deleted the patch/empty-format-class-loading-bug branch September 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasrathee-cs vikasrathee-cs Awaiting requested review from vikasrathee-cs

Assignees

@psainics psainics

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psainics